On Mon, 22 Jul 2024 14:50:33 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I added a few cases where user agent is `null`. I've not added all >> combinations as that would lead to 20-30 extra cases that add little of >> value. If I already verified that INLINE will override the lower priority >> sources individually, then it's safe to say that all possible other >> combinations of those lower priority sources will also get overridden. > > I still think there is a value in providing exhaustive coverage, especially > since the number of combination is relatively low. The added value, for > instance, is to guard against regressions introduced by other people. Hmm. I think an exhaustive set is probably overkill in this case, although I don't feel strongly one way or the other. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686725469
