On Tue, 16 Jul 2024 18:36:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> The fix looks good, presuming that you are correct, and that the comment > about needing to set the origin of the parsed value to the greatest of any > resolved reference in order to avoid storing an inline style in the shared > cache is in fact wrong. Testing should help catch any potential problems. I did some local testing as well regarding this (before I wrote the test cases) to first see if this fix would not break anything. I couldn't get inline styles that mess with `-fx-base` to "poison" each other. I also went through the caching logic, and found that any difference in inline styles results in a separate cache space -- this makes sense, because if inline styles were not taken into account when selecting the cache, then any inline style for two otherwise equal nodes could poison the other -- in other words, inline styles would not work correctly when cached if these were not taken into account, lookups or not. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1503#issuecomment-2231682096
