> This change removes the origin determination from `resolveLookups`. Instead, > the origin from the style is used. > > Although a comment in the code alluded that this may cause problem with > `INLINE` styles, this is not the case. Whenever a `Node` is associated with a > `CssStyleHelper`, a suitable shared cache is determined for its use. This > already takes into account the presence of an inline style, and only nodes > with the same inline style can share such a cache. See `Cache#getStyleMap` > and specifically this fragment where an additional selector is added for the > inline style: > > if (hasInlineStyle) { > Selector selector = > cacheContainer.getInlineStyleSelector(inlineStyle); > if (selector != null) selectors.add(selector); > }
John Hendrikx has updated the pull request incrementally with one additional commit since the last revision: Add test case ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1503/files - new: https://git.openjdk.org/jfx/pull/1503/files/8b989e83..73b910af Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1503&range=01 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1503&range=00-01 Stats: 114 lines in 1 file changed: 103 ins; 7 del; 4 mod Patch: https://git.openjdk.org/jfx/pull/1503.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1503/head:pull/1503 PR: https://git.openjdk.org/jfx/pull/1503