On Tue, 16 Jul 2024 18:36:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> The new unit test looks like it covers all the cases. As with PR #1505, this > PR mixes JUnit 4 and JUnit 5, which we really don't want to do in the same > test class. Consider converting the entire class to JUnit 5, perhaps in #1505. On closer look, it's probably best to not do that as part of #1505 since that PR only adds a couple test methods to an existing class with many preexisting tests. Similarly, this PR only adds one new test method. So I think the best options are: 1. File a new test bug and PR that converts this class to JUnit 5, that new bug would block both of the other bugs 2. Stick with JUnit 4 for both of the existing PRs Comments? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1503#issuecomment-2231626454
