On Wed, 15 May 2024 21:57:23 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> CONTRIBUTING.md line 233: >> >>> 231: * Don't worry too much about import order. Try not to change it but >>> don't worry about fighting your IDE to stop it from doing so. >>> 232: >>> 233: New code should be formatted consistently in accordance with the above >>> guidelines. However, please do not reformat existing code as part of a bug >>> fix. The makes more changes for code reviewers to track and review, and can >>> lead to merge conflicts. If you want to reformat a class, do that in a >>> separate pull request (which will need its own unique JBS bug ID). >> >> "The makes more changes" ? I think you mean "This" not "The" >> >> I'm not sure about the last sentence, it seems to encourage reformatting >> fixes which are just noise most of the time. > > Yeah, that was a typo (which I didn't notice when copying the block from the > other doc). I'll fix it. And I agree with your concern, so I'll remove the > last sentence. I agree with the concern, but I still think it's much better to encourage developers to do formatting in a separate issue (or not at all) with all the required administration, than to sneak in a formatting change in a PR that has nothing to do with formatting. I prefer the noise to be completely isolated, so that it can be ignored easily, rather than being distracted by it in a PR. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602767101
