On Sat, 18 May 2024 14:28:31 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> We have by now cleaned up our public API to avoid classes with an implicit >> no-arg constructor, so the only way this situation could arise in the future >> is if someone adds a new public class, which needs a CSR anyway. >> >> I guess it could also happen if someone proposed to delete the no-arg >> constructor, but we don't allow deleting of non-terminally-deprecated API >> anyway. Maybe it's worth changing "adds any new" to "adds, removes, or >> modifies any"? >> >> Somewhat related, these guidelines don't address what to look for when >> reviewing new API; perhaps a follow-on issue. > >> Maybe it's worth changing "adds any new" to "adds, removes, or modifies any"? > > This looks like a good idea. Done. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1609019119
