On Wed, 15 May 2024 20:12:09 GMT, Phil Race <p...@openjdk.org> wrote:
>> README-code-reviews.md line 48: >> >>> 46: All code reviews must be done via a pull request submitted against this >>> GitHub repo, [openjdk/jfx](https://github.com/openjdk/jfx). A JBS bug ID >>> must exist before the pull request will be reviewed. See >>> [CONTRIBUTING.md](CONTRIBUTING.md) for information on how to submit a pull >>> request. >>> 47: >>> 48: All fixes must be reviewed by at least one reviewer with the "Reviewer" >>> role (aka a "R"eviewer). We have a different code review threshold for >>> different types of changes. If there is disagreement as to whether a fix is >>> low-impact or high-impact, then it is considered high-impact. In other >>> words we will always err on the side of quality by "rounding up" to the >>> next higher category. The contributor can say whether they think something >>> is low-impact or high-impact, but It is up to a Reviewer to confirm this. A >>> Reviewer either adds a comment indicating that they think a single review >>> is sufficient, or else issues the Skara `/reviewers 2` command requesting a >>> second reviewer (a Reviewer can request more than 2 reviewers in some cases >>> where a fix might be especially risky or cut across multiple functional >>> areas). >> >> "but **It** is" -> it > > I think it worth noting that in skara syntax that isn't two people with the > reviewer role. > And tell people what to use if that is what they intend - eg if I have it > right It's `/reviewers 2 reviewers`, so I'll add that as an example and clarify that `/reviewers 2` is 2 with at least one reviewer. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602299262
