On Wed, 1 Nov 2023 02:28:15 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java
>> line 52:
>>
>>> 50: * by calling the {@link #update(Map)} method.
>>> 51: */
>>> 52: public class PlatformPreferences extends AbstractMap<String, Object>
>>> implements Platform.Preferences {
>>
>> Is there a need for this class to be public? It seems to me that
>> `Platform.Preferences` is public, and that in order to get the platform
>> preferences you call `Platform.getPreferences()`, which returns the
>> interface.
>>
>> Otherwise, you need to document all `public` methods (not from the
>> interface), including the constructor.
>
> `PlatformPreferences` is in the `com.sun.javafx.application.preferences`
> package, but must be accessible from the `com.sun.javafx.application`
> package. That's why it needs to be public. The class doesn't have
> undocumented public methods (aside from the constructor), but then again this
> class is also not API.
Sorry, I missed that it was in `com.sun.*`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1378516914
