On Tue, 31 Oct 2023 20:35:47 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - formatting
>> - Javadoc change
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java
> line 214:
>
>> 212:
>> 213: void fireValueChangedEvent(Map<String, ChangedValue>
>> changedEntries) {
>> 214: for (var listener : invalidationListeners) {
>
> minor: IMHO, don't use `var` when it is not clear from the same line what it
> represents.
Can just use `invalidationListeners.forEach(listener ->
listener.invalidated(this));` here.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1378270348
