On Tue, 31 Oct 2023 20:13:11 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java > line 479: > >> 477: "GTK.theme_bg_color", "backgroundColor" >> 478: ); >> 479: } > > Not sure how often these are called, but since the map returned is immutable, > you could return the same map each time. Same applies for the other 2 > application classes. It's only called once when QuantumToolkit is initialized, so there's no need to do that. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1378304357
