On Tue, 31 Oct 2023 21:05:23 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - formatting >> - Javadoc change > > modules/javafx.graphics/src/main/java/javafx/application/Appearance.java line > 31: > >> 29: * Defines the appearance of the user interface. >> 30: * >> 31: * @since 22 > > I would add an `@see > javafx.application.Platform.Preferences#appearanceProperty()` tag (if I got > the syntax right) because it's not clear how and where to use this class from > the description. > > Can there be other uses for this enum outside of the current one in the above > property? If so, it should be documented. Added the `@see` tag. There will be other uses coming in the future (window decorations and style themes). > modules/javafx.graphics/src/main/java/javafx/application/Appearance.java line > 44: > >> 42: */ >> 43: DARK >> 44: > > Minor: > > I was told once that JavaFX uses a `;` after the last enum element. > > Also no need for the extra empty line. Almost no public enumerations in JavaFX use a semicolon after the last constant (not considering those that need it because they have additional methods). Some enumerations do use a comma, but many others don't. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1378343052 PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1378342416
