On Sat, Aug 10, 2024 at 8:07 AM Armin Kuster via lists.openembedded.org <[email protected]> wrote:
> > > On 8/6/24 4:09 PM, Khem Raj wrote: > > On Mon, Aug 5, 2024 at 12:08 AM Frank de Brabander via > > lists.openembedded.org <[email protected]> > > wrote: > >> > >> > >>> Op 3 aug 2024 om 18:51 heeft akuster808 <[email protected]> het > volgende geschreven: > >>> > >>> > >>> > >>>> On 7/31/24 4:07 AM, Frank de Brabander wrote: > >>>> I was unaware of this discussion when I created the fix for master. > >>>> Note that I've silenced the TMPDIR QA message, this still needs a > >>>> proper fix in master as well. > >>>> > >>>> This indeed needs to be fixed in scarthgap as well, since the > >>>> incompatible versions do break some code. My two cents for the > available > >>>> options: > >>>> > >>>> - Revert pydantic upgrade (from 2.7.0 back to 2.6.4) > >>>> - Update pydantic-core to 2.18.1 > >>>> - Use master (pydantic 2.7.3 and pydantic-core 2.18.4) > >>>> > >>>> Would only downgrade if this is the *only* allowed option according to > >>>> the LTS branch policy. Version 2.7.x includes new features compared to > >>>> 2.6.4. Removing these with a downgrade would violate the LTS patch > policy > >>>> of not merging "ABI/API breakage". > >>> We have had this type of situation with a pkg (A) update in master and > then new lts was branched. We found out other later additional pkgs needed > to updated to work with pkg (A). pydantic update was in Master before > scarthgap was branched. > >>>> Option 2 or 3 are my preferred choices and they fall within the > >>>> "fixes for bugs" category of the LTS patch policy. Option 2 is the > smallest > >>>> change to fix the problem, but option 3 includes some additional > upstream > >>>> fixes with the update from 2.7.0 to 2.7.3. > >>> Master should be failing so if Master gets a revert of pydantic back > to 2.6.4, then Scarthgap will follow. Is this an option? - Armin > >> As far as I know master works now, so a revert would make no sense in > that case. > > Hi Armin > > > > scarthgap is relatively new and I think I would be in favor of making > > an exception for this one case. > > Well since scarthgap got the pydantic update before release, updating > pydantic-core is reasonable. I see Tim is working on the update and will > wait for him to request a merge. BR, Armin > I nearly took this version, but there were several complications in applying patches. I opted for cherry-picking as much as possible from master since that is a more typical pattern. This patch was superseded by: https://lore.kernel.org/openembedded-devel/eac1c83ac65b72f3469a3f875cd0cf1b9a2a5d6d.1723432397.git.tim.orl...@konsulko.com/ Given we were in a completely non-functional, broken situation, and 2.18.1 was never merged to master, I opted for taking 2.18.4 and that drove the upgrade of python3-pydantic itself beyond this version. Thank you for all the work on this unfortunate situation. --Tim > > >>>> > >>>> Regards, > >>>> Frank > >> > >> > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#111765): https://lists.openembedded.org/g/openembedded-devel/message/111765 Mute This Topic: https://lists.openembedded.org/mt/107073841/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
