On Tue, Aug 06, 2024 at 01:09:10PM GMT, Khem Raj wrote:
> On Mon, Aug 5, 2024 at 12:08 AM Frank de Brabander via
> lists.openembedded.org <[email protected]>
> wrote:
> >
> >
> >
> > > Op 3 aug 2024 om 18:51 heeft akuster808 <[email protected]> het
> > > volgende geschreven:
> > >
> > >
> > >
> > >> On 7/31/24 4:07 AM, Frank de Brabander wrote:
> > >> I was unaware of this discussion when I created the fix for master.
> > >> Note that I've silenced the TMPDIR QA message, this still needs a
> > >> proper fix in master as well.
> > >>
> > >> This indeed needs to be fixed in scarthgap as well, since the
> > >> incompatible versions do break some code. My two cents for the available
> > >> options:
> > >>
> > >> - Revert pydantic upgrade (from 2.7.0 back to 2.6.4)
> > >> - Update pydantic-core to 2.18.1
> > >> - Use master (pydantic 2.7.3 and pydantic-core 2.18.4)
> > >>
> > >> Would only downgrade if this is the *only* allowed option according to
> > >> the LTS branch policy. Version 2.7.x includes new features compared to
> > >> 2.6.4. Removing these with a downgrade would violate the LTS patch policy
> > >> of not merging "ABI/API breakage".
> > >
> > > We have had this type of situation with a pkg (A) update in master and
> > > then new lts was branched. We found out other later additional pkgs
> > > needed to updated to work with pkg (A). pydantic update was in Master
> > > before scarthgap was branched.
> > >>
> > >> Option 2 or 3 are my preferred choices and they fall within the
> > >> "fixes for bugs" category of the LTS patch policy. Option 2 is the
> > >> smallest
> > >> change to fix the problem, but option 3 includes some additional upstream
> > >> fixes with the update from 2.7.0 to 2.7.3.
> > >
> > > Master should be failing so if Master gets a revert of pydantic back to
> > > 2.6.4, then Scarthgap will follow. Is this an option? - Armin
> >
> > As far as I know master works now, so a revert would make no sense in that
> > case.
>
> Hi Armin
>
> scarthgap is relatively new and I think I would be in favor of making
> an exception for this one case.
Hi Khem,
thanks. Sounds good to me.
Do you prefer going to the same pydantic{,-core} version as master,
or stick with 2.7.0 and update only pydantic-core to 2.18.1?.
regards;rl
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#111646):
https://lists.openembedded.org/g/openembedded-devel/message/111646
Mute This Topic: https://lists.openembedded.org/mt/107073841/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
