thomasmueller commented on code in PR #2959:
URL: https://github.com/apache/jackrabbit-oak/pull/2959#discussion_r3428120683
##########
oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java:
##########
@@ -46,6 +46,8 @@ public void generate(FluentIterable<BinaryResource> binaries)
throws IOException
CSVPrinter printer = new CSVPrinter(new BufferedWriter(new
FileWriter(outFile, StandardCharsets.UTF_8)),
CSVFileBinaryResourceProvider.FORMAT);
closer.register(printer);
+ // commons-csv 1.2+ no longer auto-writes the header on
construction; must be explicit
Review Comment:
> that's a good indication that it should happen in a separate ticket.
It doesn't sounds reasonable to me that such a small change is in a separate
ticket. This PR is small enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
