thomasmueller commented on code in PR #2959:
URL: https://github.com/apache/jackrabbit-oak/pull/2959#discussion_r3428104734
##########
oak-parent/pom.xml:
##########
@@ -855,6 +879,166 @@
<artifactId>jsr305</artifactId>
<version>3.0.2</version>
</dependency>
+ <!-- azure-keyvault-core:1.2.6 pulls guava:30.1.1-jre, conflicting with
the direct guava
+ deps in oak-blob-cloud-azure and oak-segment-azure. Additionally,
in reactor builds
+ Maven uses oak-shaded-guava's original pom.xml rather than
dependency-reduced-pom.xml,
+ so guava:33.5.0-jre also appears as a transitive dep (making guava
optional in
+ oak-shaded-guava would eliminate that false positive, but not the
azure-keyvault conflict). -->
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>33.5.0-jre</version>
+ </dependency>
+ <!-- jackrabbit-core:2.22.3 pulls oak-jackrabbit-api:1.88.0 -->
+ <dependency>
+ <groupId>org.apache.jackrabbit</groupId>
+ <artifactId>oak-jackrabbit-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <!-- oak-auth-ldap has a direct dep on 2.12.0; api-all:2.0.1 pulls 2.8.0
-->
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-pool2</artifactId>
+ <version>2.12.0</version>
+ </dependency>
+ <!-- oak-auth-ldap has a direct dep on 2.1.12; api-all:2.0.1 pulls 2.1.3
-->
+ <dependency>
+ <groupId>org.apache.mina</groupId>
+ <artifactId>mina-core</artifactId>
+ <version>2.1.12</version>
+ </dependency>
+ <!-- parsson:1.0.5 pulls 2.0.2; elasticsearch-java:8.19.5 pulls 2.0.1 -->
+ <dependency>
+ <groupId>jakarta.json</groupId>
+ <artifactId>jakarta.json-api</artifactId>
+ <version>2.0.2</version>
+ </dependency>
+
+ <!-- jackrabbit-jcr-server:2.22.3 pulls tika-core:2.4.1; oak-lucene uses
${tika.version} -->
+ <dependency>
+ <groupId>org.apache.tika</groupId>
+ <artifactId>tika-core</artifactId>
+ <version>${tika.version}</version>
+ </dependency>
+ <!-- jetty-annotations (via spring-boot-starter-jetty:2.7.18) pulls 9.6;
tika-parsers:1.28.5 pulls 9.3 -->
+ <dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm</artifactId>
+ <version>9.6</version>
+ </dependency>
Review Comment:
> This change just adds noise here.
It is needed in order to add enforce-dependency-convergence, which is needed
to prevent problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
