amaannawab923 commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2166613721
##########
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts:
##########
@@ -60,6 +60,7 @@ export enum FeatureFlag {
SlackEnableAvatars = 'SLACK_ENABLE_AVATARS',
EnableDashboardScreenshotEndpoints = 'ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS',
EnableDashboardDownloadWebDriverScreenshot =
'ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT',
+ TableV2TimeComparisonEnabled = 'TABLE_V2_TIME_COMPARISON_ENABLED',
Review Comment:
I guess ,
There are 2 feature Flags for Ag Grid on Open source
TABLE_V2_TIME_COMPARISON_ENABLED <- This can be same across preset & Superset
CHART_PLUGINS_EXPERIMENTAL <- We shouldnt keep Ag Grid Under experimental as
Interactive table has its own flags of ag Grid there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
