amaannawab923 commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2166473244
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/package.json:
##########
@@ -27,6 +27,8 @@
"@react-icons/all-files": "^4.1.0",
"@types/d3-array": "^2.9.0",
"@types/react-table": "^7.7.20",
+ "ag-grid-community": "^33.1.1",
Review Comment:
Thats true , even i think so ... I tried to exclude it from peerDependencies
but the ci cd would fail saying that this is an extraneous dependancy as per
eslint rule & must be included in Peer Dependancy
That makes alot of sense of keeping the main Dep in @superset-ui/core and
that would be a follow up pr where the core Component of Ag Grid will be moved
to @superset-ui/core to be used by both Sqllab and Viz Plugins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
