amaannawab923 commented on code in PR #33517: URL: https://github.com/apache/superset/pull/33517#discussion_r2166606123
########## superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/components/Pagination.tsx: ########## @@ -0,0 +1,216 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/* eslint-disable theme-colors/no-literal-colors */ +import { styled, t } from '@superset-ui/core'; +import { + VerticalLeftOutlined, + VerticalRightOutlined, + LeftOutlined, + RightOutlined, +} from '@ant-design/icons'; + +const PaginationContainer = styled.div` Review Comment: This pagination component was implemented for the sake of implementing Server Pagination on Community Module since server pagination isnt available on Community I made 1 to 1 copy of the Client side pagination component of Ag Grid table ... since Ag Grid doesnt provide access to its components ... I created it from scratch P.s I didnt know that ant design provided pagination ... Let me see if i can Use Ant design pagination -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
