mistercrunch commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2164603858
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/package.json:
##########
@@ -27,6 +27,8 @@
"@react-icons/all-files": "^4.1.0",
"@types/d3-array": "^2.9.0",
"@types/react-table": "^7.7.20",
+ "ag-grid-community": "^33.1.1",
Review Comment:
should this be in `peerDependencies`? Also wondering if we need to rethink
where the main deps should live and how the peerDeps should be set. I think
what makes more sense is to add the main dep in `@superset-ui/core` and have
the main package/app AND plugins set them as peerDep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
