michael-s-molina commented on PR #33271: URL: https://github.com/apache/superset/pull/33271#issuecomment-2842756022
Thanks for the PR @amaannawab923. > This pr fixes a bug introduced as part of the previous pr of Exclude Filter Values It's good to think about PR descriptions as historical documents that someone will read in the future to understand the reasons for a change. For that reason, it's a good practice to always add as much context as possible to the PR description, given that people reading the PR might not have any previous context about what you're working on. Linking the previous PR that caused the regression is also helpful especially when dealing with releases. Could you improve the PR description by linking the previous PR and filling the BEFORE/AFTER SCREENSHOTS and TESTING INSTRUCTIONS sections? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
