geido commented on PR #33271: URL: https://github.com/apache/superset/pull/33271#issuecomment-2842680079
Echoing @evans suggestion on adding tests to make this mergiable and to avoid that the same regressions will enter the codebase in the future. A few issues from manual testing: We might need to tweak the "Select All" - "Deselect All" UI here as it cuts this off in small sizes. cc @msyavuz for help.  Not sure if it possible to keep the Select only in one line to avoid this UI behavior. I think we do it correctly in horizontal mode so hopefully it should be easy to implement in vertical mode too  This bug seems a bit more serious. I have created a filter with a default value, saved and used the filter normally. I then updated the default value with a different value and saved but the now the filter is empty and shows no default. What is even more concerning is that my browser completely freezes when doing that operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
