amaannawab923 commented on PR #33271:
URL: https://github.com/apache/superset/pull/33271#issuecomment-2840136615
@geido , @rusackas There is a bug on master branch which will break the
native filter features in future
dispatch(setDataMaskForFilterChangesComplete(filterChanges,
oldFilters));
This method erases the DataMask extra form data & filterState on default
Value selected ....
The impact
If you create a native filter with a Default value as first selected
& then modify the native filter & enable some new feature
The native filter will crash
Steps to reproduce:
1. Create a Dashboard with chart , In this case Top Timezones
2. Now create a native filter with following configuration:
Filter Value is required
Select first filter value by default
Can select multiple values
Disable/Unselect Allow creation of new values
<img width="1728" alt="Screenshot 2025-04-30 at 1 40 29 AM"
src="https://github.com/user-attachments/assets/878ff2b9-974e-4215-a56e-a3577ee981cb";
/>
3. Create the filter & now it will work properly ... with default filter
<img width="1728" alt="Screenshot 2025-04-30 at 1 43 20 AM"
src="https://github.com/user-attachments/assets/b5a72db1-b62d-4073-964f-5a05f0ef3d79";
/>
4. Now modify the filter & enable Allow Creation of New Values & save it
<img width="1728" alt="Screenshot 2025-04-30 at 1 44 16 AM"
src="https://github.com/user-attachments/assets/7044ef6f-ddee-40fe-bdfe-1f7fefa0d215";
/>
5. The chart will crash since this method
dispatch(setDataMaskForFilterChangesComplete(filterChanges, oldFilters)); will
erase the filterState & extraFormData which was not required in this case
![Uploading Screenshot 2025-04-30 at 1.45.51 AM.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
