amaannawab923 commented on PR #33271: URL: https://github.com/apache/superset/pull/33271#issuecomment-2840050677
<img width="1728" alt="Screenshot 2025-04-30 at 1 06 54 AM" src="https://github.com/user-attachments/assets/16546a68-7fa9-4730-b0d4-b38e4edaa087"; /> @geido There is a bug on the master branch in which if the Select First by default is checked, then the DataMask filter State is erased by the method dispatch(setDataMaskForFilterChangesComplete(filterChanges, oldFilters)); Causing re renders & would impact other functionailities related to Native filters including inverse selection... I have tried out on the Master branch Steps to reproduce Create a Dashboard with a chart first 1. Place the Chart on the grid 2. Create a native filter with configuration , Select First value by default & Filter Value is required 3. Save this This method dispatch(setDataMaskForFilterChangesComplete(filterChanges, oldFilters)); will erase the filter State & extra form data in case of default Value or first value is required causing it to become invalid for a while & cause re renders -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
