michael-s-molina commented on PR #31590: URL: https://github.com/apache/superset/pull/31590#issuecomment-2622632814
@mistercrunch I pulled this branch and did a quick navigation. I understand the importance of merging this before the breaking window closes and that we can fix the issues during the RC rounds but I think we need to polish a little bit more before merging this PR. Here's some examples of things it would be good to fix before merging this PR: 1. The home page style looks off and there's a weird toggle at the top. I believe this is used to change from light to dark theme and it should be hidden. <img width="1911" alt="Screenshot 2025-01-29 at 16 02 43" src="https://github.com/user-attachments/assets/e58515c2-34c4-495c-bf07-094ccdc3c815"; /> 2. Tabs style <img width="1890" alt="Screenshot 2025-01-29 at 16 03 57" src="https://github.com/user-attachments/assets/ea59410a-c401-4807-9a49-9a7368de607d"; /> 3. Empty container icon <img width="1907" alt="Screenshot 2025-01-29 at 16 13 24" src="https://github.com/user-attachments/assets/a83f32f9-74eb-4f89-ac7a-e3f108326ed3"; /> 4. Icons size <img width="1910" alt="Screenshot 2025-01-29 at 16 04 41" src="https://github.com/user-attachments/assets/1a2f2c8e-b077-4fc5-b3d3-09c054c0e66e"; /> 5. Controls, drag-and-drop image, buttons <img width="1908" alt="Screenshot 2025-01-29 at 16 05 19" src="https://github.com/user-attachments/assets/bc1f9a60-71ef-46d2-aa41-24853714ca55"; /> 6. Font sizes for the error messages <img width="1899" alt="Screenshot 2025-01-29 at 16 06 37" src="https://github.com/user-attachments/assets/80ae89a8-ad7d-42e0-8c24-1ec098be3c86"; /> 7. Menu buttons <img width="305" alt="Screenshot 2025-01-29 at 16 07 01" src="https://github.com/user-attachments/assets/1b8ee54d-751c-4d3c-9f30-a71c2bcdb350"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
