zxs1633079383 commented on PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#issuecomment-3607032709
1. About the scope issue you mentioned
Just to confirm my understanding:
Are you mainly referring to the commit history containing mixed or unrelated
commits, rather than the actual file changes in this PR?If so, I can reorganize
or squash the commits to ensure the PR history is clean and strictly focused on
UDT-related changes.
Please let me know your preferred approach ā Iām happy to adjust or split
the PR if needed.
2. Mutable enum state
The previous withTypeName() usage has already been fully removed.
No enum mutation remains, and the typeName pipeline is now completely
stateless and thread-safe.
3. Types.OTHER / JSONB behavior
Current behavior:
UDTs remain Types.OTHER in metadata
JSON ā "json"
JSONB ā "jsonb"
JSON / JSONB bypass UDT logic
Other Types.OTHER use normal fallback
No UDT_GENERIC mapping in the current PR
Bind phase only uses typeName to construct PGobject
I will add focused tests to validate JSON / JSONB / UDT / non-UDT behavior.
4. UDT discovery
I will improve UDT loading with:
an enable/disable option
optional caching , and more in the future.
and add tests for protocol behavior.
5. Tests
I will add the missing tests for:
UDT bind/describe/execute
JSON / JSONB
non-UDT Types.OTHER
minimal reproducible scenarios
Thanks again for your time and guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
