zxs1633079383 opened a new pull request, #37259:
URL: https://github.com/apache/shardingsphere/pull/37259
Fixes #36978.
This PR is the complete version of the PostgreSQL custom type / VARBIT fix.
It contains:
1. All functional changes from PR #37216
(PostgreSQL extended protocol fixes, typeName propagation,
UDT/enum/domain handling, VARBIT support, JSONB consistency, etc.)
2. Full updates to unit tests and E2E tests
to ensure that the entire build passes CI, including:
- typeName propagation across metadata / binder / prepared statement
- extended-protocol Parse → Describe → Bind → Execute test cases
- adjustments to affected SQL parsing, metadata and YAML tests
- spotless & checkstyle compliance
- E2E pipelines for MySQL / MariaDB / PostgreSQL
3. All checks pass locally:
- `./mvnw spotless:apply -Pcheck`
- `./mvnw clean install -B -T1C -Pcheck`
Changes proposed in this pull request:
- Restore correct JSON/JSONB OIDs (114 / 3802)
- Add VARBIT / BIT VARYING value parser and metadata support
- Propagate typeName across ColumnMetaData → ShardingSphereColumn → binder
- Resolve PostgreSQL parameter type & typeName during Describe phase
- Construct PGobject safely in Bind phase with fallback typeName
- Remove mutable enum state and avoid cross-statement leakage
- Update all relevant unit tests and E2E cases to match new behavior
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally :
`./mvnw spotless:apply -Pcheck`
`./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip
-e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
This PR aims to provide a stable, fully tested version of the PostgreSQL
custom
type implementation, and I am happy to address any additional comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]