Copilot commented on code in PR #37259:
URL: https://github.com/apache/shardingsphere/pull/37259#discussion_r2581455349
##########
test/it/rewriter/src/test/java/org/apache/shardingsphere/test/it/rewriter/engine/scenario/MixSQLRewriterIT.java:
##########
@@ -39,21 +39,21 @@ class MixSQLRewriterIT extends SQLRewriterIT {
protected Collection<ShardingSphereSchema> mockSchemas(final String
schemaName) {
Collection<ShardingSphereTable> tables = new LinkedList<>();
tables.add(new ShardingSphereTable("t_account", Arrays.asList(
- new ShardingSphereColumn("account_id", Types.INTEGER, true,
true, false, true, false, false),
- new ShardingSphereColumn("password", Types.VARCHAR, false,
false, false, true, false, false),
- new ShardingSphereColumn("amount", Types.DECIMAL, false,
false, false, true, false, false),
- new ShardingSphereColumn("status", Types.TINYINT, false,
false, false, false, false, false)),
+ new ShardingSphereColumn("account_id", Types.INTEGER, true,
true, "int", false, true, false, false),
+ new ShardingSphereColumn("password", Types.VARCHAR, false,
false, "varchar", false, true, false, false),
+ new ShardingSphereColumn("amount", Types.DECIMAL, false,
false, "decimal", false, true, false, false),
+ new ShardingSphereColumn("status", Types.TINYINT, false,
false, "int", false, false, false, false)),
Review Comment:
Incorrect typeName for `status` column. The column has type `Types.TINYINT`
but typeName is set to `"int"`. It should be `"tinyint"` to match the data type.
##########
infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContextBuilderTest.java:
##########
@@ -131,26 +131,26 @@ void
assertBuildRouteSQLRewriteResultWithEmptyPrimaryKeyMeta() {
private Collection<ShardingSphereSchema> buildSchemas() {
Collection<ShardingSphereTable> tables = new LinkedList<>();
- tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new
ShardingSphereColumn("order_id", Types.INTEGER, true, false, false, true,
false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("status", Types.INTEGER, false,
false, false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
- tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new
ShardingSphereColumn("item_id", Types.INTEGER, true, false, false, true, false,
false),
- new ShardingSphereColumn("order_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("status", Types.VARCHAR, false,
false, false, true, false, false),
- new ShardingSphereColumn("c_date", Types.TIMESTAMP, false,
false, false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new
ShardingSphereColumn("order_id", Types.INTEGER, true, false, "int", false,
true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.INTEGER, false,
false, "int", false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new
ShardingSphereColumn("item_id", Types.INTEGER, true, false, "int", false, true,
false, false),
+ new ShardingSphereColumn("order_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.VARCHAR, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("c_date", Types.TIMESTAMP, false,
false, "int", false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
Review Comment:
Incorrect typeName for `c_date` column. The column has type
`Types.TIMESTAMP` but typeName is set to `"int"`. It should be `"timestamp"` to
match the data type.
##########
kernel/sql-federation/compiler/src/test/java/org/apache/shardingsphere/sqlfederation/compiler/compiler/it/SQLStatementCompilerIT.java:
##########
@@ -96,145 +96,145 @@ private Collection<SqlOperatorTable> getOperatorTables() {
}
private ShardingSphereTable createOrderFederationTableMetaData() {
- ShardingSphereColumn orderIdColumn = new
ShardingSphereColumn("order_id", Types.VARCHAR, true, false, false, true,
false, false);
- ShardingSphereColumn userIdColumn = new
ShardingSphereColumn("user_id", Types.VARCHAR, false, false, false, true,
false, false);
- ShardingSphereColumn statusColumn = new ShardingSphereColumn("status",
Types.VARCHAR, false, false, false, true, false, false);
+ ShardingSphereColumn orderIdColumn = new
ShardingSphereColumn("order_id", Types.VARCHAR, true, false, "varchar", false,
true, false, false);
+ ShardingSphereColumn userIdColumn = new
ShardingSphereColumn("user_id", Types.VARCHAR, false, false, "varchar", false,
true, false, false);
+ ShardingSphereColumn statusColumn = new ShardingSphereColumn("status",
Types.VARCHAR, false, false, "varchar", false, true, false, false);
return new ShardingSphereTable("t_order_federate",
Arrays.asList(orderIdColumn, userIdColumn, statusColumn),
Collections.emptyList(), Collections.emptyList());
}
private ShardingSphereTable createUserInfoTableMetaData() {
- ShardingSphereColumn userIdColumn = new
ShardingSphereColumn("user_id", Types.VARCHAR, true, false, false, true, false,
false);
- ShardingSphereColumn informationColumn = new
ShardingSphereColumn("information", Types.VARCHAR, false, false, false, true,
false, false);
+ ShardingSphereColumn userIdColumn = new
ShardingSphereColumn("user_id", Types.VARCHAR, true, false, "varchar", false,
true, false, false);
+ ShardingSphereColumn informationColumn = new
ShardingSphereColumn("information", Types.VARCHAR, false, false, "varchar",
false, true, false, false);
return new ShardingSphereTable("t_user_info",
Arrays.asList(userIdColumn, informationColumn), Collections.emptyList(),
Collections.emptyList());
}
private ShardingSphereTable createTOrderTableMetaData() {
- ShardingSphereColumn orderIdColumn = new
ShardingSphereColumn("order_id", Types.BIGINT, true, false, false, true, false,
false);
- ShardingSphereColumn userIdColumn = new
ShardingSphereColumn("user_id", Types.INTEGER, false, false, false, true,
false, false);
- ShardingSphereColumn statusColumn = new ShardingSphereColumn("status",
Types.VARCHAR, false, false, false, true, false, false);
- ShardingSphereColumn merchantIdColumn = new
ShardingSphereColumn("merchant_id", Types.INTEGER, false, false, false, true,
false, false);
- ShardingSphereColumn remarkColumn = new ShardingSphereColumn("remark",
Types.VARCHAR, false, false, false, true, false, false);
- ShardingSphereColumn creationDateColumn = new
ShardingSphereColumn("creation_date", Types.DATE, false, false, false, true,
false, false);
+ ShardingSphereColumn orderIdColumn = new
ShardingSphereColumn("order_id", Types.BIGINT, true, false, "bigint", false,
true, false, false);
+ ShardingSphereColumn userIdColumn = new
ShardingSphereColumn("user_id", Types.INTEGER, false, false, "varchar", false,
true, false, false);
Review Comment:
Incorrect typeName for `user_id` column. The column has type `Types.INTEGER`
but typeName is set to `"varchar"`. It should be `"int"` to match the data type.
##########
proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/PostgreSQLServerPreparedStatement.java:
##########
@@ -48,6 +48,8 @@ public final class PostgreSQLServerPreparedStatement
implements ServerPreparedSt
private final List<PostgreSQLColumnType> parameterTypes;
+ private final List<String> parameterTypeNames;
Review Comment:
getParameterTypeNames exposes the internal representation stored in field
parameterTypeNames. The value may be modified [after this call to
getParameterTypeNames](1).
getParameterTypeNames exposes the internal representation stored in field
parameterTypeNames. The value may be modified [after this call to
getParameterTypeNames](2).
##########
infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/sql/context/ExecutionContextBuilderTest.java:
##########
@@ -131,26 +131,26 @@ void
assertBuildRouteSQLRewriteResultWithEmptyPrimaryKeyMeta() {
private Collection<ShardingSphereSchema> buildSchemas() {
Collection<ShardingSphereTable> tables = new LinkedList<>();
- tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new
ShardingSphereColumn("order_id", Types.INTEGER, true, false, false, true,
false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("status", Types.INTEGER, false,
false, false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
- tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new
ShardingSphereColumn("item_id", Types.INTEGER, true, false, false, true, false,
false),
- new ShardingSphereColumn("order_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("status", Types.VARCHAR, false,
false, false, true, false, false),
- new ShardingSphereColumn("c_date", Types.TIMESTAMP, false,
false, false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName1", Arrays.asList(new
ShardingSphereColumn("order_id", Types.INTEGER, true, false, "int", false,
true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.INTEGER, false,
false, "int", false, true, false, false)), Collections.emptySet(),
Collections.emptyList()));
+ tables.add(new ShardingSphereTable("logicName2", Arrays.asList(new
ShardingSphereColumn("item_id", Types.INTEGER, true, false, "int", false, true,
false, false),
+ new ShardingSphereColumn("order_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.VARCHAR, false,
false, "int", false, true, false, false),
Review Comment:
Incorrect typeName for `status` column. The column has type `Types.VARCHAR`
but typeName is set to `"int"`. It should be `"varchar"` to match the data type.
##########
infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/from/type/SimpleTableSegmentBinderTest.java:
##########
@@ -60,12 +60,12 @@ void assertBindTableNotExists() {
private ShardingSphereMetaData createMetaData() {
ShardingSphereSchema schema = mock(ShardingSphereSchema.class,
RETURNS_DEEP_STUBS);
when(schema.getTable("t_order").getAllColumns()).thenReturn(Arrays.asList(
- new ShardingSphereColumn("order_id", Types.INTEGER, true,
false, false, true, false, false),
- new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, false, true, false, false),
- new ShardingSphereColumn("status", Types.INTEGER, false,
false, false, true, false, false)));
+ new ShardingSphereColumn("order_id", Types.INTEGER, true,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("user_id", Types.INTEGER, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("status", Types.INTEGER, false,
false, "int", false, true, false, false)));
when(schema.getTable("pg_database").getAllColumns()).thenReturn(Arrays.asList(
- new ShardingSphereColumn("datname", Types.VARCHAR, false,
false, false, true, false, false),
- new ShardingSphereColumn("datdba", Types.VARCHAR, false,
false, false, true, false, false)));
+ new ShardingSphereColumn("datname", Types.VARCHAR, false,
false, "int", false, true, false, false),
+ new ShardingSphereColumn("datdba", Types.VARCHAR, false,
false, "int", false, true, false, false)));
Review Comment:
Incorrect typeName for `datname` and `datdba` columns. Both columns have
type `Types.VARCHAR` but typeName is set to `"int"`. It should be `"varchar"`
to match the data type.
##########
proxy/frontend/dialect/mysql/src/test/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/text/query/MySQLMultiStatementsProxyBackendHandlerTest.java:
##########
@@ -185,8 +185,8 @@ private ContextManager mockContextManager() {
when(result.getMetaDataContexts().getMetaData().getProps().<Integer>getValue(ConfigurationPropertyKey.KERNEL_EXECUTOR_SIZE)).thenReturn(1);
when(result.getMetaDataContexts().getMetaData().getProps().<Boolean>getValue(ConfigurationPropertyKey.SQL_SHOW)).thenReturn(false);
when(result.getMetaDataContexts().getMetaData().getProps().<Integer>getValue(ConfigurationPropertyKey.MAX_CONNECTIONS_SIZE_PER_QUERY)).thenReturn(1);
- ShardingSphereTable table = new ShardingSphereTable("t",
Arrays.asList(new ShardingSphereColumn("id", Types.BIGINT, true, false, false,
false, true, false),
- new ShardingSphereColumn("v", Types.INTEGER, false, false,
false, false, true, false)), Collections.emptyList(), Collections.emptyList());
+ ShardingSphereTable table = new ShardingSphereTable("t",
Arrays.asList(new ShardingSphereColumn("id", Types.BIGINT, true, false, "int",
false, false, true, false),
Review Comment:
Incorrect typeName for `id` column. The column has type `Types.BIGINT` but
typeName is set to `"int"`. It should be `"bigint"` to match the data type.
##########
proxy/frontend/dialect/postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/PostgreSQLServerPreparedStatement.java:
##########
@@ -48,6 +48,8 @@ public final class PostgreSQLServerPreparedStatement
implements ServerPreparedSt
private final List<PostgreSQLColumnType> parameterTypes;
Review Comment:
getParameterTypes exposes the internal representation stored in field
parameterTypes. The value may be modified [after this call to
getParameterTypes](1).
getParameterTypes exposes the internal representation stored in field
parameterTypes. The value may be modified [after this call to
getParameterTypes](2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
