ptrdom commented on PR #194: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/194#issuecomment-2661378365
> I am not sure that renaming so many config settings is a good idea. Can we at least produce a doc that details all the renames? That is a list of c1 becomes c2 pairs. Sure I can make a list. We do need to decide if we want to make changes a correct implementation that also support runtime plugin config or want to preserve backwards compatibility. For example, current `main` branch durable state uses `buffer-size` setting from query settings. I think that is simply incorrect implementation that should not have made it into `main` branch or at least `1.0.0` release. There are two ways I see to do it better: 1. Move `buffer-size` under `pekko.persistence.r2dbc` key, where shared settings are located. Both durable state and query plugin inherit this key and can have their own overrides to it. This is what this PR does. 2. Have query and durable state their own `buffer-size` settings, without inheritance from shared settings under `pekko.persistence.r2dbc`. Shared settings would not have `buffer-size`, because `buffer-size` is feature-specific and should have been made so. I think this would be ideal solution, but would bloat this PR with even more config changes. We cannot make runtime plugin config work without making plugin configuration self-contained, which it is not right now, so we *have* to move/rename configuration to some extent to achieve self-containment. If there is great focus on keeping backwards compatibility and sticking to keeping configuration as it is now, then we cannot provide runtime plugin config feature in this repository. This feature will have to be a major release feature, or not a feature at all. What are your thoughts on this @pjfanning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
