ptrdom commented on PR #194: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/194#issuecomment-2657772468
> 1. Shared settings are now provided through inheritance: > https://github.com/apache/pekko-persistence-r2dbc/blob/b28968057679e621591ac9bc21bab0daba13eebb/core/src/main/resources/reference.conf#L4-L8 > > Ideally the break up of shared settings would still be done, but it does not seem as critical. Maybe even without the break up of shared settings it would still make sense to put them under `pekko.persistence.r2dbc.shared` key, which would then be inherited by plugin configs instead of whole `pekko.persistence.r2dbc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
