ptrdom opened a new pull request, #194: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/194
Resolves #https://github.com/apache/pekko-persistence-r2dbc/issues/181. TODO: - [ ] Break up `pekko.persistence.rdbc.shared` config. Shared config is now bloated - plugins have access to config keys they are not using. Ideally shared configuration should be broken into multiple feature-specific sub-configs and plugins would only depend on sub-configs that they are using. - [ ] Implement shared connection factories. With changes to config and `ConnectionFactoryProvider` the connection factories are no longer shared between plugins by default and there is no way to make them shared. Need to re-implement this feature, best idea now seems to be to copy `pekko-persistence-jdbc` implementation. - [ ] Deal with `projection` module. Even though runtime config is available already with `R2dbcProjectionSettings`, changes to config of `core` module and `ConnectionFactoryProvider` do affect `projection` module. This PR will become (or already is) rather large, maybe there are sensible ways to break it up. By sensible I mean that the project would be in a releasable state between sub-PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org