ptrdom commented on code in PR #194:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/194#discussion_r1994293605
##########
projection/src/test/scala/org/apache/pekko/projection/r2dbc/EventSourcedPubSubSpec.scala:
##########
@@ -43,23 +43,23 @@ import org.slf4j.LoggerFactory
object EventSourcedPubSubSpec {
- val config: Config = ConfigFactory
- .parseString("""
- pekko.persistence.r2dbc {
- journal.publish-events = on
- query {
+ val config: Config = ConfigFactory.load(
Review Comment:
Alternative would be to merge with `TestConfig.config`, but have both
`journal.publish-events = on` and `query.publish-events = on` defined in test
config, so that `query.publish-events` depends not on a substitution, but on an
override though test config. It seemed to me like a better solution to first
merge then load/resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
