ptupitsyn commented on code in PR #6391:
URL: https://github.com/apache/ignite-3/pull/6391#discussion_r2282630155
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecutePartitionedRequest.java:
##########
@@ -65,12 +67,14 @@ public static CompletableFuture<ResponseWriter> process(
int partitionId = in.unpackInt();
Job job = ClientComputeJobUnpacker.unpackJob(in,
clientContext.hasFeature(PLATFORM_COMPUTE_JOB));
+ UUID taskId = clientContext.hasFeature(COMPUTE_EVENTS) ?
in.unpackUuidNullable() : null;
Review Comment:
Same can be said for `ClientComputeExecuteColocatedRequest` calls coming
from `ColocatedJobTarget, right? Let's just add it to all requests to keep the
protocol consistent.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecutePartitionedRequest.java:
##########
@@ -65,12 +67,14 @@ public static CompletableFuture<ResponseWriter> process(
int partitionId = in.unpackInt();
Job job = ClientComputeJobUnpacker.unpackJob(in,
clientContext.hasFeature(PLATFORM_COMPUTE_JOB));
+ UUID taskId = clientContext.hasFeature(COMPUTE_EVENTS) ?
in.unpackUuidNullable() : null;
Review Comment:
Same can be said for `ClientComputeExecuteColocatedRequest` calls coming
from `ColocatedJobTarget`, right? Let's just add it to all requests to keep the
protocol consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
