ptupitsyn commented on code in PR #6391:
URL: https://github.com/apache/ignite-3/pull/6391#discussion_r2282727099
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecutePartitionedRequest.java:
##########
@@ -65,12 +67,14 @@ public static CompletableFuture<ResponseWriter> process(
int partitionId = in.unpackInt();
Job job = ClientComputeJobUnpacker.unpackJob(in,
clientContext.hasFeature(PLATFORM_COMPUTE_JOB));
+ UUID taskId = clientContext.hasFeature(COMPUTE_EVENTS) ?
in.unpackUuidNullable() : null;
Review Comment:
I can imagine a colocated execution for a group of keys. Let's have `taskId`
in all requests even if it is not used yet for some of them.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecutePartitionedRequest.java:
##########
@@ -65,12 +67,14 @@ public static CompletableFuture<ResponseWriter> process(
int partitionId = in.unpackInt();
Job job = ClientComputeJobUnpacker.unpackJob(in,
clientContext.hasFeature(PLATFORM_COMPUTE_JOB));
+ UUID taskId = clientContext.hasFeature(COMPUTE_EVENTS) ?
in.unpackUuidNullable() : null;
Review Comment:
I can imagine a colocated execution for a group of keys. Let's have `taskId`
in all compute requests even if it is not used yet for some of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
