valepakh commented on code in PR #6391:
URL: https://github.com/apache/ignite-3/pull/6391#discussion_r2281681688
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteColocatedRequest.java:
##########
@@ -73,10 +73,10 @@ public static CompletableFuture<ResponseWriter> process(
return readTableAsync(tableId, tables).thenCompose(table ->
readTuple(schemaId, noValueSet, tupleBytes, table, true)
.thenCompose(keyTuple -> {
- Builder metadataBuilder =
ComputeEventMetadata.builder(Type.SINGLE)
+ ComputeEventMetadataBuilder metadataBuilder =
ComputeEventMetadata.builder(Type.SINGLE)
+ .eventUser(clientContext.userDetails())
.tableName(table.name())
-
.initiatorClient(clientContext.remoteAddress().toString())
- .eventUser(clientContext.userDetails());
+
.clientAddress(clientContext.remoteAddress().toString());
Review Comment:
I'm not sure how it's one less allocation, the serializer will definitely
call `toString` anyway.
Also I tried to do that and it will require jumping some hoops since we pass
the metadata through the network messaging and it requires opening `java.net`
package in the `java.base` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
