valepakh commented on code in PR #6391:
URL: https://github.com/apache/ignite-3/pull/6391#discussion_r2281685160
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteColocatedRequest.java:
##########
@@ -73,10 +73,10 @@ public static CompletableFuture<ResponseWriter> process(
return readTableAsync(tableId, tables).thenCompose(table ->
readTuple(schemaId, noValueSet, tupleBytes, table, true)
.thenCompose(keyTuple -> {
- Builder metadataBuilder =
ComputeEventMetadata.builder(Type.SINGLE)
+ ComputeEventMetadataBuilder metadataBuilder =
ComputeEventMetadata.builder(Type.SINGLE)
+ .eventUser(clientContext.userDetails())
.tableName(table.name())
-
.initiatorClient(clientContext.remoteAddress().toString())
- .eventUser(clientContext.userDetails());
+
.clientAddress(clientContext.remoteAddress().toString());
Review Comment:
I can pass the address as is but call `toString` in the events factory.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecutePartitionedRequest.java:
##########
@@ -65,12 +67,14 @@ public static CompletableFuture<ResponseWriter> process(
int partitionId = in.unpackInt();
Job job = ClientComputeJobUnpacker.unpackJob(in,
clientContext.hasFeature(PLATFORM_COMPUTE_JOB));
+ UUID taskId = clientContext.hasFeature(COMPUTE_EVENTS) ?
in.unpackUuidNullable() : null;
Review Comment:
We need task id only for the broadcast jobs (and later for the map-reduce)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
