ptupitsyn commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2024215742
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java:
##########
@@ -391,24 +413,47 @@ public static TableNotFoundException
tableIdNotFoundException(Integer tableId) {
* @param in Unpacker.
* @param out Packer.
* @param resources Resource registry.
+ * @param txManager Tx manager.
* @return Transaction, if present, or null.
*/
public static @Nullable InternalTransaction readTx(
ClientMessageUnpacker in,
ClientMessagePacker out,
- ClientResourceRegistry resources
+ ClientResourceRegistry resources,
+ @Nullable TxManager txManager
) {
if (in.tryUnpackNil()) {
return null;
}
try {
- var tx =
resources.get(in.unpackLong()).get(InternalTransaction.class);
+ long id = in.unpackLong();
+ if (id == 0) {
Review Comment:
@ascherbakoff please do the following to avoid magic numbers and make the
code easier to understand:
* Add a new class to `ignite-client-common` module:
`org.apache.ignite.internal.client.proto.tx.ClientTxUtils`
* Add a constant `TX_ID_DIRECT = 0` to that class
* Use this constant here (server) and in `ClientTable.writeTx` (client)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
