rpuch commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1986786827
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -291,7 +292,11 @@ public void start() {
throw new IgniteInternalException(INTERNAL_ERR, "Error in
multicast listener", e);
}
} finally {
- sockets.forEach(MulticastSocket::close);
+ try {
+ IgniteUtils.closeAll(sockets);
+ } catch (Exception e) {
+ throw new IgniteInternalException(INTERNAL_ERR, "Could not
close multicast sockets", e);
Review Comment:
On a second thought: we should not throw from a finally block, so probably
it makes sense to just log the exception (with WARN) and don't rethrow it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
