Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1986807811
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -271,17 +232,67 @@ private static Collection<NetworkInterface>
getEligibleNetworkInterfaces() {
public void close() {
stopped = true;
- for (CompletableFuture<Void> future : listenerFutures) {
- future.cancel(true);
- }
-
- shutdownAndAwaitTermination(threadPool, 10, TimeUnit.SECONDS);
+ shutdownAndAwaitTermination(listenerThreadPool, 10, TimeUnit.SECONDS);
}
@Override
public void start() {
- for (NetworkInterface networkInterface :
getEligibleNetworkInterfaces()) {
- listenerFutures.add(runAsync(() ->
listenOnInterface(networkInterface), threadPool));
- }
+ listenerThreadPool.submit(() -> {
+ List<MulticastSocket> sockets = new ArrayList<>();
+
+ try {
+ for (NetworkInterface networkInterface :
getEligibleNetworkInterfaces()) {
+ MulticastSocket socket = new
MulticastSocket(multicastPort);
+ configureSocket(socket, networkInterface,
POLLING_TIMEOUT_MILLIS);
Review Comment:
Eye-balling :) discussed, changed to 100ms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
