Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984448028
##########
modules/network-api/src/main/java/org/apache/ignite/internal/network/NodeFinder.java:
##########
@@ -17,17 +17,23 @@
package org.apache.ignite.internal.network;
-import java.util.List;
+import java.util.Collection;
+import org.apache.ignite.internal.close.ManuallyCloseable;
import org.apache.ignite.network.NetworkAddress;
/**
* Interface for services responsible for discovering the initial set of
network cluster members.
*/
-public interface NodeFinder {
+public interface NodeFinder extends ManuallyCloseable {
/**
* Discovers the initial set of cluster members and returns their network
addresses.
*
* @return addresses of initial cluster members.
*/
- List<NetworkAddress> findNodes();
+ Collection<NetworkAddress> findNodes();
Review Comment:
Discussed that it is OK in this case
##########
modules/network-api/src/main/java/org/apache/ignite/internal/network/NodeFinder.java:
##########
@@ -17,17 +17,23 @@
package org.apache.ignite.internal.network;
-import java.util.List;
+import java.util.Collection;
+import org.apache.ignite.internal.close.ManuallyCloseable;
import org.apache.ignite.network.NetworkAddress;
/**
* Interface for services responsible for discovering the initial set of
network cluster members.
*/
-public interface NodeFinder {
+public interface NodeFinder extends ManuallyCloseable {
/**
* Discovers the initial set of cluster members and returns their network
addresses.
*
* @return addresses of initial cluster members.
*/
- List<NetworkAddress> findNodes();
+ Collection<NetworkAddress> findNodes();
Review Comment:
(Discussed that it is OK in this case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
