Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1986709519
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -85,21 +91,23 @@ public class MulticastNodeFinder implements NodeFinder {
* @param multicastPort Multicast port.
* @param resultWaitMillis Wait time for responses.
* @param ttl Time-to-live for multicast packets.
- * @param localAddress Local node address.
+ * @param nodeName Node name.
+ * @param localAddressToAdvertise Local node address.
*/
public MulticastNodeFinder(
String multicastGroup,
int multicastPort,
int resultWaitMillis,
int ttl,
- InetSocketAddress localAddress
+ String nodeName,
+ InetSocketAddress localAddressToAdvertise
) {
this.multicastSocketAddress = new InetSocketAddress(multicastGroup,
multicastPort);
this.multicastPort = multicastPort;
this.resultWaitMillis = resultWaitMillis;
this.ttl = ttl;
- this.localAddress = localAddress;
- this.threadPool = Executors.newFixedThreadPool(4);
+ this.localAddressToAdvertise = localAddressToAdvertise;
+ this.threadPool = Executors.newFixedThreadPool(4,
NamedThreadFactory.create(nodeName, "rocksdb-storage-engine-pool", LOG));
Review Comment:
Refactored to use a single thread executor for listening (iterating between
sockets with short timeout)
Also create a threadpool with number of threads equal to the number of
eligible network interfaces, and shutdown it after discovery process is finished
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
