sashapolo commented on code in PR #5212:
URL: https://github.com/apache/ignite-3/pull/5212#discussion_r1954575342
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/outgoing/OutgoingSnapshot.java:
##########
@@ -162,30 +170,38 @@ void freezeScopeUnderMvLock() {
try {
frozenMeta = takeSnapshotMeta();
- txDataCursor = partition.getAllTxMeta();
+ txDataCursor = txState.getAllTxMeta();
} finally {
releaseMvLock();
}
}
private PartitionSnapshotMeta takeSnapshotMeta() {
- RaftGroupConfiguration config =
partition.committedGroupConfiguration();
+ PartitionStorageAccess partitionStorageWithMaxAppliedIndex =
partitionsByTableId.values().stream()
+ .max(comparingLong(PartitionStorageAccess::lastAppliedIndex))
+ .orElseThrow();
Review Comment:
My thinking was that we shouldn't have snapshots going if the zone is empty.
But now I think that this assumption is incorrect, we can still have some
entries (like when safe time sync will be implemented). I'll try to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
