sashapolo commented on code in PR #5212:
URL: https://github.com/apache/ignite-3/pull/5212#discussion_r1954319669
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/PartitionStorageAccess.java:
##########
@@ -31,33 +30,17 @@
import org.apache.ignite.internal.storage.StorageException;
import org.apache.ignite.internal.storage.StorageRebalanceException;
import org.apache.ignite.internal.storage.TxIdMismatchException;
-import org.apache.ignite.internal.tx.TxMeta;
-import org.apache.ignite.internal.util.Cursor;
import org.jetbrains.annotations.Nullable;
/**
* Small abstractions for partition storages that includes only methods,
mandatory for the snapshot storage.
*/
-public interface PartitionAccess {
- /**
- * Returns the key that uniquely identifies the corresponding partition.
- */
- PartitionKey partitionKey();
-
- /**
- * Creates a cursor to scan all meta of transactions.
- *
- * <p>All metas that exist at the time the method is called will be
returned, in transaction ID order as an unsigned 128 bit integer.
- */
- Cursor<IgniteBiTuple<UUID, TxMeta>> getAllTxMeta();
+public interface PartitionStorageAccess {
Review Comment:
Why?
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/ZonePartitionKey.java:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.partition.replicator.raft.snapshot;
+
+import java.util.Objects;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Uniquely identifies a partition. This is a pair of zone ID and partition
number (aka partition ID).
+ */
+public class ZonePartitionKey implements PartitionKey {
+ private final int zoneId;
+
+ private final int partitionId;
+
+ /**
+ * Returns ID of the zone.
+ */
+ public int tableId() {
Review Comment:
oops, thanks for noticing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
