sashapolo commented on code in PR #5212:
URL: https://github.com/apache/ignite-3/pull/5212#discussion_r1955808396
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/PartitionSnapshotStorageFactory.java:
##########
@@ -46,84 +51,101 @@
* {@code true}, and {@link SnapshotWriter#addFile(String)} throws an
exception.
*/
public class PartitionSnapshotStorageFactory implements SnapshotStorageFactory
{
+ private final PartitionKey partitionKey;
+
/** Topology service. */
private final TopologyService topologyService;
/** Snapshot manager. */
private final OutgoingSnapshotsManager outgoingSnapshotsManager;
- /** Partition storage. */
- private final PartitionAccess partition;
+ /**
+ * Partition storages grouped by table ID.
+ */
+ private final Int2ObjectMap<PartitionStorageAccess> partitionsByTableId =
synchronize(new Int2ObjectOpenHashMap<>());
+
+ private final PartitionTxStateAccess txStateStorage;
private final CatalogService catalogService;
- private final @Nullable SnapshotMeta startupSnapshotMeta;
-
/** Incoming snapshots executor. */
private final Executor incomingSnapshotsExecutor;
- /**
- * Constructor.
- *
- * @param topologyService Topology service.
- * @param outgoingSnapshotsManager Snapshot manager.
- * @param partition MV partition storage.
- * @param catalogService Access to the Catalog.
- * @param incomingSnapshotsExecutor Incoming snapshots executor.
- * @see SnapshotMeta
- */
- @SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType")
+ /** Constructor. */
public PartitionSnapshotStorageFactory(
+ PartitionKey partitionKey,
TopologyService topologyService,
OutgoingSnapshotsManager outgoingSnapshotsManager,
- PartitionAccess partition,
+ PartitionTxStateAccess txStateStorage,
CatalogService catalogService,
Executor incomingSnapshotsExecutor
) {
+ this.partitionKey = partitionKey;
this.topologyService = topologyService;
this.outgoingSnapshotsManager = outgoingSnapshotsManager;
- this.partition = partition;
+ this.txStateStorage = txStateStorage;
this.catalogService = catalogService;
this.incomingSnapshotsExecutor = incomingSnapshotsExecutor;
+ }
- // We must choose the minimum applied index for local recovery so that
we don't skip the raft commands for the storage with the
- // lowest applied index and thus no data loss occurs.
- long lastIncludedRaftIndex = partition.minLastAppliedIndex();
- long lastIncludedRaftTerm = partition.minLastAppliedTerm();
-
- int lastCatalogVersionAtStart = catalogService.latestCatalogVersion();
-
- if (lastIncludedRaftIndex == 0) {
- startupSnapshotMeta = null;
- } else {
- startupSnapshotMeta = snapshotMetaAt(
- lastIncludedRaftIndex,
- lastIncludedRaftTerm,
-
Objects.requireNonNull(partition.committedGroupConfiguration()),
- lastCatalogVersionAtStart,
-
collectNextRowIdToBuildIndexesAtStart(lastCatalogVersionAtStart),
- partition.leaseStartTime(),
- partition.primaryReplicaNodeId(),
- partition.primaryReplicaNodeName()
- );
- }
+ /**
+ * Adds a given table partition storage to the snapshot storage, managed
by this factory.
Review Comment:
Added TODO and will fix in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
