sashapolo commented on code in PR #5212: URL: https://github.com/apache/ignite-3/pull/5212#discussion_r1954559581
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ########## @@ -554,10 +564,20 @@ private CompletableFuture<?> createZonePartitionReplicationNode( txManager, safeTimeTracker, storageIndexTracker, - zonePartitionId + zonePartitionId, + outgoingSnapshotsManager ); - var listeners = new Listeners(raftGroupListener); + var snapshotStorageFactory = new PartitionSnapshotStorageFactory( + new ZonePartitionKey(zonePartitionId.zoneId(), zonePartitionId.partitionId()), Review Comment: I don't know if I fully understand the question, but this key is used in `OutgoingSnapshotsManager` to manage all snapshots on the node, so partitionId is not enough -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org