valepakh commented on code in PR #4778:
URL: https://github.com/apache/ignite-3/pull/4778#discussion_r1861941271
##########
modules/client-common/src/test/java/org/apache/ignite/internal/client/proto/ClientComputeJobPackerUnpackerTest.java:
##########
@@ -78,6 +84,13 @@ private static List<Object> pojo() {
return List.of(Pojo.generateTestPojo());
}
+ private static List<Arguments> notMarshalled() {
+ return List.of(
+ arguments(Tuple.create(), ComputeJobType.MARSHALLED_TUPLE),
Review Comment:
For me packing is what we do with the message packer/unpacker and
marshalling is what we do with the marshaller.
So we can have marshalled packed data, if the job declares custom
marshaller, the data will be marshalled first, and then the resulting byte
array will be packed for transfer (between client and server). And network
messaging is another case, but I don't have a name for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
