ptupitsyn commented on code in PR #4778:
URL: https://github.com/apache/ignite-3/pull/4778#discussion_r1861667736
##########
modules/client-common/src/test/java/org/apache/ignite/internal/client/proto/ClientComputeJobPackerUnpackerTest.java:
##########
@@ -78,6 +84,13 @@ private static List<Object> pojo() {
return List.of(Pojo.generateTestPojo());
}
+ private static List<Arguments> notMarshalled() {
+ return List.of(
+ arguments(Tuple.create(), ComputeJobType.MARSHALLED_TUPLE),
Review Comment:
Marshalling, packing, serialization - those are all synonyms in our case, I
think. Or is there a difference?
> drop the MARSHALLED_ prefix for the tuple and pojo types
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
