ptupitsyn commented on code in PR #4778:
URL: https://github.com/apache/ignite-3/pull/4778#discussion_r1858014581
##########
modules/client-common/src/test/java/org/apache/ignite/internal/client/proto/ClientComputeJobPackerUnpackerTest.java:
##########
@@ -78,6 +84,13 @@ private static List<Object> pojo() {
return List.of(Pojo.generateTestPojo());
}
+ private static List<Arguments> notMarshalled() {
+ return List.of(
+ arguments(Tuple.create(), ComputeJobType.MARSHALLED_TUPLE),
Review Comment:
I'm not sure if `MARSHALLED_` prefix is necessary.
* All types of job args and results can be in marshalled or unmarshalled
state
* A job can take a tuple and return a primitive, etc, so this is not a job
type, but a job argument/result type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
