valepakh commented on code in PR #4778:
URL: https://github.com/apache/ignite-3/pull/4778#discussion_r1861058240
##########
modules/client-common/src/test/java/org/apache/ignite/internal/client/proto/ClientComputeJobPackerUnpackerTest.java:
##########
@@ -78,6 +84,13 @@ private static List<Object> pojo() {
return List.of(Pojo.generateTestPojo());
}
+ private static List<Arguments> notMarshalled() {
+ return List.of(
+ arguments(Tuple.create(), ComputeJobType.MARSHALLED_TUPLE),
Review Comment:
There's only one piece of information - what type is it. It can be either
native type, or a tuple, or a pojo, or an object, marshalled with the custom
marshalled.
I'd say there's a confusion between "packing" as in `ClientMessagePacker`
and "marshalling" as in `Marshaller`.
Maybe we can drop the `MARSHALLED_` prefix for the tuple and pojo types,
would this be clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
