[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2271: IGNITE-19862: Revise error codes for SQL module

[via GitHub]

AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1262391328


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -785,7 +779,7 @@ private <S, T> void updateCommandOption(
             try {
                 optInfo.validator.accept(value0);
             } catch (Throwable e) {
-                throw new IgniteException(QUERY_VALIDATION_ERR, String.format(
+                throw new IgniteException(STMT_VALIDATION_ERR, String.format(

Review Comment:
   ```suggestion
                   throw new SqlException(STMT_VALIDATION_ERR, String.format(
   ```



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverter.java:
##########
@@ -800,7 +794,7 @@ private <S, T> void updateCommandOption(
 
     private void checkPositiveNumber(int num) {
         if (num < 0) {
-            throw new IgniteException(QUERY_VALIDATION_ERR, "Must be 
positive:" + num);
+            throw new IgniteException(STMT_VALIDATION_ERR, "Must be positive:" 
+ num);

Review Comment:
   ```suggestion
               throw new SqlException(STMT_VALIDATION_ERR, "Must be positive:" 
+ num);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org