lowka commented on code in PR #2271: URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1263512314
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/session/SessionExpiredException.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.session; + +import static org.apache.ignite.lang.IgniteStringFormatter.format; + +import org.apache.ignite.lang.IgniteInternalException; + +/** + * Thrown when session has been expired but not yet been collected by cleaner thread. + */ +public class SessionExpiredException extends IgniteInternalException { + + private static final long serialVersionUID = 0L; + + /** Constructor. */ + public SessionExpiredException(SessionId sessionId, Throwable cause) { + super(format("Session has been expired [{}]", sessionId), cause); Review Comment: SessionExpiredException now extends RuntimeException. ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/session/SessionNotFoundException.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.session; + +import static org.apache.ignite.lang.IgniteStringFormatter.format; + +import org.apache.ignite.lang.IgniteInternalException; + +/** + * Thrown when session has been expired AND collected by cleaner thread. + */ +public class SessionNotFoundException extends IgniteInternalException { + + private static final long serialVersionUID = 0L; + + /** Constructor. */ + public SessionNotFoundException(SessionId sessionId) { + super(format("Session not found [{}]", sessionId)); Review Comment: SessionNotFoundException now extends RuntimeException. ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/Commons.java: ########## @@ -392,7 +392,7 @@ public static <T> T compile(Class<T> interfaceType, String body) { return (T) cbe.createInstance(new StringReader(body)); } catch (Exception e) { - throw new SqlException(EXPRESSION_COMPILATION_ERR, e); + throw new SqlException(INTERNAL_ERR, "Unable to compile expression", e); Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
